Skip to content

Add NYC CRE assistant recipe - #2300

Closed
Miki-AG wants to merge 2 commits into
google:mainfrom
Miki-AG:add-nyc-cre-assistant
Closed

Miki-AG wants to merge 2 commits into
google:mainfrom
Miki-AG:add-nyc-cre-assistant

Conversation

@Miki-AG

@Miki-AG Miki-AG commented Jul 26, 2026

Copy link
Copy Markdown

Summary

Adds a Python ADK recipe for NYC commercial real estate public-record lookup.

The recipe demonstrates a single ADK agent using three file-based skills and
three deterministic tools to:

  • Resolve clear NYC building addresses to BBLs using NYC Geoclient
  • Summarize public owner evidence from PLUTO, ACRIS, and NYS DOS records
  • Summarize recorded mortgage and debt evidence from ACRIS metadata

Validation

  • ruff format .
  • ruff check .
  • uv run pytest
  • uv run validate contrib/python/nyc-cre-assistant
  • uv run python .github/scripts/check_recipe_pyproject.py contrib/python/nyc-cre-assistant
  • uv run python .github/scripts/check_env_vars.py contrib/python/nyc-cre-assistant
  • uv lock --check

@google-cla

google-cla Bot commented Jul 26, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Miki-AG
Miki-AG marked this pull request as ready for review July 26, 2026 14:14
@Miki-AG

Miki-AG commented Jul 26, 2026

Copy link
Copy Markdown
Author

CLA is now signed. This PR is ready for review when a maintainer has a chance to approve the workflows.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has had no activity for 60 days, so it has been labelled stale.

If it is still wanted, a comment or a push is enough to reset the clock. Otherwise it will be closed automatically in 30 days.

Nothing about this is final — a closed pull request reopens with one click, and your commits are untouched on your own branch.

Maintainers: apply keep-open to exempt this permanently. Thresholds live in .github/policy.yml under stale_policy.

@github-actions github-actions Bot added the stale No activity for the period set in .github/policy.yml label Sep 28, 2026
@tommywagz
tommywagz self-requested a review as a code owner October 23, 2026 02:09

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated House Rules review — 1 finding(s).

Also, on lines this PR does not change:

  • contrib/python/nyc-cre-assistant/Dockerfile:1 — [CRITICAL] required file missing: Dockerfile (.github/policy.yml required_files)

return Agent(
name="nyc_cre_assistant",
model=Gemini(
model=os.getenv("MODEL_NAME", "gemini-3.5-flash"),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MINOR] env read carries a hardcoded default (second argument is a hardcoded default); 2 occurrence(s) across 2 file(s). Defaults belong in .env.example, not in the code (contrib/python/nyc-cre-assistant/app/agent.py:53; contrib/python/nyc-cre-assistant/app/tools/bbl_address.py:35)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Security review — 2 finding(s).


Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.

NYS_DOMAIN,
DOS_ACTIVE_CORPORATIONS_DATASET,
{
"$where": f"upper(current_entity_name) = '{normalized}'",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MAJOR] This is an unescaped entity name interpolated directly into a SoQL query. Can we please escape single quotes in normalized so names with apostrophes don't cause query syntax errors or injection?

DOS_ACTIVE_CORPORATIONS_DATASET,
{
"$where": (
f"upper(current_entity_name) like '%{normalized}%'"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MAJOR] same issue as above

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Maintainability review — 4 finding(s).


Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.

)

NYC_DOMAIN = "data.cityofnewyork.us"
ACRIS_LEGALS_DATASET = "8h5j-fqxa"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MINOR] duplicated in find_owner.py

}


def _map_acris_party(record: JsonRecord) -> JsonRecord:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MINOR] Can we move _map_acris_party() to shared.py? It seems identical to the implementation in find_owner.py.

"recordedDate": document.get("recordedDate"),
"recordedAmount": document.get("recordedAmount"),
"crfn": document.get("crfn"),
"lendersOrMortgagees": _party_names_by_type(document, "2"),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MINOR] Can we extract "1" and "2" into named constants? It would clarify these ACRIS party type codes.

"""Fetch JSON from a public API."""
request = Request(url, headers=headers or {})
try:
with urlopen(request, timeout=30) as response:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MINOR] extract timeout to named constant

@github-actions

Copy link
Copy Markdown
Contributor

There is a problem with the Antigravity CLI Hygiene PR review. Please check the action logs for details.

@github-actions

Copy link
Copy Markdown
Contributor

There is a problem with the Antigravity CLI Correctness PR review. Please check the action logs for details.

@github-actions github-actions Bot added the status/not-ready-for-review Review requests held until checks pass and bot comments are resolved label Oct 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request isn't ready for review yet.

I removed the review request for tommywagz until the items below are fixed.

Failing checks (5)

Fix the failing checks. Once everything is green I will re-request the review automatically, so there is no need to ping anyone. This is re-checked every 15 minutes.

Applied by the review gate (.github/review-gate-config.yml); the status/not-ready-for-review label is removed on release.

@tommywagz

Copy link
Copy Markdown
Collaborator

The repo has moved to be more of a feature display of ADK and less of a menagerie of different agents that the community has made. This is a great use case and a good implementation idea but doesn't use many features past ADK>=2.0.0 or incorporate any GCP tools to show a recipe that another user or agent can follow or learn from.

@tommywagz tommywagz closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale No activity for the period set in .github/policy.yml status/not-ready-for-review Review requests held until checks pass and bot comments are resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants